Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused strings in the Localization Files #3120

Closed
barronpm opened this issue May 15, 2020 · 3 comments
Closed

Unused strings in the Localization Files #3120

barronpm opened this issue May 15, 2020 · 3 comments

Comments

@barronpm
Copy link
Member

@barronpm barronpm commented May 15, 2020

Describe the bug
Currently, the "HeaderCameraUploads" string in the localization files is unused and should be removed. Further investigation should be done on if there are other unused strings.

@stale
Copy link

@stale stale bot commented Sep 12, 2020

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale label Sep 12, 2020
@barronpm barronpm added confirmed and removed stale labels Sep 14, 2020
@jlechem
Copy link
Contributor

@jlechem jlechem commented Oct 1, 2020

I will remove the unused item.

@joshuaboniface
Copy link
Member

@joshuaboniface joshuaboniface commented Oct 17, 2020

Quoting my reply from #4308

Since these are all handled by Weblate, removing them here is not ideal as there will be bi-directional confusion (merge conflicts here, Weblate going screwy there).

They waste a miniscule amount of space and don't hurt anything, and peacemeal cleanup is a pain until we get most of the strings normalized.

I'm going to close this out; please don't be discouraged by this, it's just how the system is set up.

Basically, removing strings from translations - or making any changes to translations at all - should be done only through Weblate. I believe there's a mass-cleanup option of some kind, but I haven't looked into it in detail.

In effect the translation folder should be off-limits from the GitHub side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants