Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Windows Terminal Preview #9831
Comments
|
Hey @Studio384! Thanks for this suggestion. Windows Terminal support was added a few versions ago (see #9047). You can configure the preferred terminal app from the Integrations pane on the settings modal. I have just upgraded my local installation of Windows Terminal to v1.0 and Desktop keeps detecting it correctly. I'm going to close this issue, but please feel free to reopen with repro steps if for some reason you can't manage to get it working. |
|
Windows Terminal != Windows Terminal Preview Terminal Preview is the beta release channel for Windows Terminal. It cannot be detected by Desktop right now. |
|
Thanks for the clarification @Studio384 ! You're right then, I think support to it can easily be added by following the same approach we use for Windows Terminal (source). Would you be open to contribute on this? |
|
I've never done it before, but will give it a try. |
|
So this sorta isn't required. Basically trying to debug myself microsoft/terminal#7188 it would appear that both Windows Terminal and Window Terminal Preview share I believe effectively the Windows Terminal would need to expose a different Exe or hook to differentiate between the two. |
Describe the feature or problem you’d like to solve
Microsoft released Windows Terminal Preview yesterday. It would be nice if GitHub Desktop was able to detect it.
Proposed solution
Adds an option to the shells available to use.
Additional context
N/A