Merged
Conversation
tamasvajk
changed the title
tamasvajk
commented
Aug 12, 2020
calumgrant
previously requested changes
Aug 13, 2020
Contributor
I agree. You can add for instance the test mentioned here: https://github.com/github/codeql-csharp-team/issues/48#issuecomment-668536295. |
Contributor
Author
|
I though about adding the test, and then decided that the AST printing would already cover testing this too (through |
Contributor
Author
|
@calumgrant I think the |
tamasvajk
force-pushed
the
feature/partial-methods
branch
from
4952f0b to
beeadea
Compare
Merged
hvitved
approved these changes
Aug 20, 2020
hvitved
dismissed
calumgrant’s stale review
Comments addressed; dismissing so we can get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.