Skip to content

/ kratos

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config versions meta schema #608

Merged
merged 5 commits into from Aug 4, 2020
Merged

feat: config versions meta schema #608

merged 5 commits into from Aug 4, 2020

Conversation

@zepatrik
Copy link
Member

zepatrik commented Jul 29, 2020

Related issue

Prepares #590

Proposed changes

The newly added schema detects the schema version and maps it to the corresponding release on GitHub. There will be a script to automatically add new entries in our release pipeline.
@zepatrik
feat: config versions meta schema
Verified
This commit was signed with a verified signature.
zepatrik Patrik
GPG key ID: EC2C5B3670210CA0 Learn about signing commits
Loading status checks…
4fc2607
@aeneasr
aeneasr reviewed Jul 30, 2020
View changes
Copy link
Member

aeneasr left a comment

This is great! Let's do that!
.schema/config.schema.json Show resolved Hide resolved
.schema/config.schema.json Outdated Show resolved Hide resolved
zepatrik added 2 commits Aug 3, 2020
@zepatrik
Merge branch 'master' into versioned-config-schema
Verified
This commit was signed with a verified signature.
zepatrik Patrik
GPG key ID: EC2C5B3670210CA0 Learn about signing commits
Loading status checks…
1bcdf31
@zepatrik
u
Verified
This commit was signed with a verified signature.
zepatrik Patrik
GPG key ID: EC2C5B3670210CA0 Learn about signing commits
Loading status checks…
0f1af32
@aeneasr
aeneasr approved these changes Aug 4, 2020
View changes
Copy link
Member

aeneasr left a comment

Can this be merged now?
@zepatrik zepatrik marked this pull request as ready for review Aug 4, 2020
@zepatrik
zepatrik reviewed Aug 4, 2020
View changes
.schema/version.schema.json Outdated Show resolved Hide resolved
zepatrik added 2 commits Aug 4, 2020
@zepatrik
change to our meta schema
Verified
This commit was signed with a verified signature.
zepatrik Patrik
GPG key ID: EC2C5B3670210CA0 Learn about signing commits
d8cbf3b
@zepatrik
Merge branch 'master' into versioned-config-schema
Verified
This commit was signed with a verified signature.
zepatrik Patrik
GPG key ID: EC2C5B3670210CA0 Learn about signing commits
Loading status checks…
f920d55
@zepatrik
Copy link
Member Author

zepatrik commented Aug 4, 2020

Ready to be merged from my side
@zepatrik zepatrik mentioned this pull request Aug 4, 2020
Merged
@zepatrik zepatrik merged commit d218662 into master Aug 4, 2020
10 of 11 checks passed
10 of 11 checks passed
coverage/coveralls Coverage decreased (-0.01%) to 50.406%
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: generate Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-cockroach Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-postgres Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-sqlite Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
tbr Workflow: tbr
Details
@zepatrik zepatrik deleted the versioned-config-schema branch Aug 4, 2020
This was referenced Aug 11, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zepatrik @aeneasr
You can’t perform that action at this time.