Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnexpected behaviour for VCS repository #7747
Open
Labels
Milestone
Comments
|
What do you mean by "everything broke"? AFAIK packagist and I believe composer too will ignore the name entirely except for in the default branch. |
|
I noticed in #7756 (comment) that weird things may happen if the package name changes. If there is a root identifier, it's applied to everything. If there is not, the name is pulled from every tag/branch. |
|
Hmm in a composer vcs repo maybe.. on packagist though the name must be present when submitting and then we just keep that forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When defining a custom VCS repository, the package name is determined by the root identifier (often the
masterbranch). When scanning tags of said repository, we do not verify if thecomposer.jsonof each tag contains the same package name.I know this scenario is unlikely to occur; but I actually had someone in my team run into this (by mistake).
Short (simplified) description:
foo/bar.2.x, where they changed the name tofoo/baz(not sure why, irrelevant).2.x.xreleases from the2.xbranch for a while which Composer gladly picked up as new versions forfoo/bar, but once they merged the2.xbranch intomaster, everything broke.This of course was a mistake on the user's end, but it seems like we could guard against this by rejecting tags with
composer.jsonschemas that do not contain the same package name as the root identifier.