Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-inspector-already-activated-cli to parallel #34755

Merged
merged 0 commits into from Aug 18, 2020

Conversation

Copy link
Member

@Trott Trott commented Aug 13, 2020

There doesn't seem to be a reason for this test to have to stay in
sequential. It appears to have been placed there out of caution.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Aug 13, 2020
@Trott Trott added the request-ci label Aug 13, 2020
@github-actions github-actions bot removed the request-ci label Aug 13, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Aug 13, 2020

@Trott Trott added the review wanted label Aug 16, 2020
@addaleax addaleax added the author ready label Aug 18, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Aug 18, 2020

Landed in 76f86c3

@Trott Trott merged commit 76f86c3 into nodejs:master Aug 18, 2020
8 checks passed
@Trott Trott deleted the 2-parallel branch Aug 18, 2020
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
There doesn't seem to be a reason for this test to have to stay in
sequential. It appears to have been placed there out of caution.

PR-URL: #34755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
There doesn't seem to be a reason for this test to have to stay in
sequential. It appears to have been placed there out of caution.

PR-URL: #34755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this issue Sep 22, 2020
There doesn't seem to be a reason for this test to have to stay in
sequential. It appears to have been placed there out of caution.

PR-URL: #34755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this issue Sep 22, 2020
There doesn't seem to be a reason for this test to have to stay in
sequential. It appears to have been placed there out of caution.

PR-URL: #34755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready review wanted test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants