Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41410: Fix outdated info in mkstemp docs #21701

Merged
merged 4 commits into from Aug 14, 2020
Merged

bpo-41410: Fix outdated info in mkstemp docs #21701

merged 4 commits into from Aug 14, 2020

Conversation

xrisk
Copy link
Contributor

@xrisk xrisk commented Aug 2, 2020 •
edited by miss-islington

@xrisk
Doc: fix outdated info in mkstemp docs
3fda29a 
Choosing to open a file in binary or text mode makes a difference
on *all* platforms since Python 3.x
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Aug 2, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@xrisk

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

ericvsmith
ericvsmith requested changes Aug 2, 2020
View changes
Copy link
Member

@ericvsmith ericvsmith left a comment

One small point about truthiness.

@bedevere-bot
Copy link

bedevere-bot commented Aug 2, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@xrisk
Copy link
Contributor Author

xrisk commented Aug 2, 2020

I have made the requested changes; please review again

@ericvsmith I didn’t quite get what you. Is this what you meant?

@bedevere-bot
Copy link

bedevere-bot commented Aug 2, 2020

Thanks for making the requested changes!

@ericvsmith, @rhettinger: please review the changes made to this pull request.

ericvsmith
ericvsmith requested changes Aug 2, 2020
View changes
Copy link
Member

@ericvsmith ericvsmith left a comment

When this small issue is addressed and the CLA is signed, we can merge this.

Doc/library/tempfile.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Aug 2, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@xrisk
Copy link
Contributor Author

xrisk commented Aug 3, 2020

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Aug 3, 2020

Thanks for making the requested changes!

@ericvsmith, @rhettinger: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith Aug 3, 2020
ericvsmith
ericvsmith reviewed Aug 3, 2020
View changes
Copy link
Member

@ericvsmith ericvsmith left a comment

This looks good, thanks. Now it's just waiting on the CLA (Contributor License Agreement).

@xrisk
Copy link
Contributor Author

xrisk commented Aug 7, 2020

Hi do I need to do anything else here?

@ericvsmith ericvsmith added needs backport to 3.7 needs backport to 3.8 needs backport to 3.9 🤖 automerge PR will be merged once it's been approved and all CI passed labels Aug 14, 2020
@miss-islington miss-islington merged commit e55de68 into python:master Aug 14, 2020
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 14, 2020

Thanks @xrisk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2020
@xrisk @miss-islington
bpo-41410: Fix outdated info in mkstemp docs (pythonGH-21701)
6d6e82b 
Automerge-Triggered-By: @ericvsmith
(cherry picked from commit e55de68)

Co-authored-by: Rishav Kundu <rk@rishav.io>
@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2020

GH-21873 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2020

GH-21874 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2020

GH-21875 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2020
@xrisk @miss-islington
bpo-41410: Fix outdated info in mkstemp docs (pythonGH-21701)
f6e9f36 
Automerge-Triggered-By: @ericvsmith
(cherry picked from commit e55de68)

Co-authored-by: Rishav Kundu <rk@rishav.io>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2020
@xrisk @miss-islington
bpo-41410: Fix outdated info in mkstemp docs (pythonGH-21701)
b4cdc05 
Automerge-Triggered-By: @ericvsmith
(cherry picked from commit e55de68)

Co-authored-by: Rishav Kundu <rk@rishav.io>
miss-islington added a commit that referenced this pull request Aug 14, 2020
@miss-islington @xrisk
bpo-41410: Fix outdated info in mkstemp docs (GH-21701)
2a9f709 
Automerge-Triggered-By: @ericvsmith
(cherry picked from commit e55de68)

Co-authored-by: Rishav Kundu <rk@rishav.io>
miss-islington added a commit that referenced this pull request Aug 14, 2020
@miss-islington @xrisk
bpo-41410: Fix outdated info in mkstemp docs (GH-21701)
7c28841 
Automerge-Triggered-By: @ericvsmith
(cherry picked from commit e55de68)

Co-authored-by: Rishav Kundu <rk@rishav.io>
@xrisk xrisk deleted the mkstemp-docfix branch Aug 14, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@xrisk @shihai1991
bpo-41410: Fix outdated info in mkstemp docs (pythonGH-21701)
dec5548 
Automerge-Triggered-By: @ericvsmith
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@xrisk
bpo-41410: Fix outdated info in mkstemp docs (pythonGH-21701)
51d3952 
Automerge-Triggered-By: @ericvsmith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith

@rhettinger rhettinger

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xrisk @the-knights-who-say-ni @bedevere-bot @miss-islington @ericvsmith @rhettinger