Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd RepositoriesService.CompareCommitsRaw method. #1582
+89
−1
Conversation
codecov
bot
commented
Jul 21, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
=======================================
Coverage 67.95% 67.95%
=======================================
Files 96 96
Lines 8762 8781 +19
=======================================
+ Hits 5954 5967 +13
- Misses 1898 1902 +4
- Partials 910 912 +2
Continue to review full report at Codecov.
|
|
Thank you, @bradleymcallister97 ! Then we will be ready for a second LGTM before merging. |
| @@ -241,6 +240,34 @@ func (s *RepositoriesService) CompareCommits(ctx context.Context, owner, repo st | |||
| return comp, resp, nil | |||
| } | |||
|
|
|||
| // CompareCommitsRaw compares a range of commits with each other in raw (diff or patch) format. | |||
| // | |||
This comment has been minimized.
This comment has been minimized.
gmlewis
Jul 23, 2020
Collaborator
Can you please add the following comments from the official docs?
Suggested change
| // | |
| // | |
| // Both "base" and "head" must be branch names in "repo". | |
| // To compare branches across other repositories in the same network as "repo", | |
| // use the format "<USERNAME>:branch". | |
| // |
|
Thank you, @bradleymcallister97 ! Awaiting second LGTM before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bradleymcallister97 commentedJul 21, 2020
Follows the same high-level pattern as set out in PR #481 with PullRequestsService.GetRaw method.