Add hooks support for PubSubHubBub API

google · joshuabezaleel · joshuabezaleel · joshuabezaleel · May 27, 2020 · googlebot
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// CreatePubSubHubBubrequest lets servers register receive updates when a topic is updated
+// using publish/subscribe protocol with GitHub as the hub for the repositories.
-// CreatePubSubHubBubrequest lets servers register receive updates when a topic is updated
-// using publish/subscribe protocol with GitHub as the hub for the repositories.
+// CreatePubSubHubbubRequest lets servers register to receive updates when a topic is updated
+// using a publish/subscribe protocol with GitHub as the hub for the repositories.
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// PubSubHubBubRequest represents the request to be send
+// for the GitHub's publish/subscribe hub protocol.
-// PubSubHubBubRequest represents the request to be send
-// for the GitHub's publish/subscribe hub protocol.
+// PubSubHubbubRequest represents the request to be sent
+// for GitHub's publish/subscribe hub protocol.
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// for the GitHub's publish/subscribe hub protocol.
+//
+// GitHub API docs: https://developer.github.com/v3/repos/hooks/#subscribing
+type PubSubHubBubRequest struct {
-type PubSubHubBubRequest struct {
+type PubSubHubbubRequest struct {
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+	Event string `json:"events,omitempty"`
+}
+
+type pubSubHubBubPayload struct {
-type pubSubHubBubPayload struct {
+type pubSubHubbubPayload struct {
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// using publish/subscribe protocol with GitHub as the hub for the repositories.
+//
+// GitHub API docs: https://developer.github.com/v3/repos/hooks/#pubsubhubbub
+func (s *RepositoriesService) CreatePubSubHubBubRequest(ctx context.Context, request *PubSubHubBubRequest) (*Response, error) {
-func (s *RepositoriesService) CreatePubSubHubBubRequest(ctx context.Context, request *PubSubHubBubRequest) (*Response, error) {
+func (s *RepositoriesService) CreatePubSubHubbubRequest(ctx context.Context, request *PubSubHubbubRequest) (*Response, error) {
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+
+	hubTopic := fmt.Sprintf("/%v/%v/events/%v", request.HubTopic.Owner, request.HubTopic.Repo, request.HubTopic.Event)
+
+	pubSubHubBubReq := &pubSubHubBubPayload{
-	pubSubHubBubReq := &pubSubHubBubPayload{
+	pubSubHubbubReq := &pubSubHubbubPayload{
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+		HubSecret:   request.HubSecret,
+	}
+
+	req, err := s.client.NewRequest("POST", u, pubSubHubBubReq)
-	req, err := s.client.NewRequest("POST", u, pubSubHubBubReq)
+	req, err := s.client.NewRequest("POST", u, pubSubHubbubReq)
diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go
@@ -197,3 +197,27 @@ func TestRepositoriesService_TestHook_invalidOwner(t *testing.T) {
 	_, err := client.Repositories.TestHook(context.Background(), "%", "%", 1)
 	testURLParseError(t, err)
 }
+
+func TestRepositoriesService_TestPubSubHubBub(t *testing.T) {
-func TestRepositoriesService_TestPubSubHubBub(t *testing.T) {
+func TestRepositoriesService_TestPubSubHubbub(t *testing.T) {
diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go
+		testMethod(t, r, "POST")
+	})
+
+	pubSubHubBubreq := &PubSubHubBubRequest{
-	pubSubHubBubreq := &PubSubHubBubRequest{
+	pubSubHubbubreq := &PubSubHubbubRequest{
diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go
+		HubCallback: "http://postbin.org/123",
+	}
+
+	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
-	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
+	_, err := client.Repositories.CreatePubSubHubbubRequest(context.Background(), pubSubHubbubreq)
diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go
+
+	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
+	if err != nil {
+		t.Errorf("Repositories.CreatePubSubHubBubrequest returned error: %v", err)
-		t.Errorf("Repositories.CreatePubSubHubBubrequest returned error: %v", err)
+		t.Errorf("Repositories.CreatePubSubHubbubRequest returned error: %v", err)
diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go
+		HubCallback: "http://postbin.org/123",
+	}
+
+	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
-	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
+	_, err := client.Repositories.CreatePubSubHubbubRequest(context.Background(), pubSubHubbubreq)
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
@@ -224,3 +249,27 @@ func (s *RepositoriesService) TestHook(ctx context.Context, owner, repo string,
 	}
 	return s.client.Do(ctx, req, nil)
 }
+
+// CreatePubSubHubBubrequest lets servers register receive updates when a topic is updated
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// using publish/subscribe protocol with GitHub as the hub for the repositories.
+//
+// GitHub API docs: https://developer.github.com/v3/repos/hooks/#pubsubhubbub
+func (s *RepositoriesService) CreatePubSubHubBubRequest(ctx context.Context, request *PubSubHubBubRequest) (*Response, error) {
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
@@ -98,6 +98,31 @@ type createHookRequest struct {
 	Active *bool                  `json:"active,omitempty"`
 }

+// PubSubHubBubRequest represents the request to be send
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+// GitHub API docs: https://developer.github.com/v3/repos/hooks/#subscribing
+type PubSubHubBubRequest struct {
+	HubMode     string `json:"hub_mode,omitempty"`
+	HubTopic    Topic  `json:"hub_topic,omitempty"`
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+	HubSecret   string `json:"hub_secret,omitempty"`
+}
+
+// Topic represents GitHub repository and its particular event.
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+	Event string `json:"events,omitempty"`
+}
+
+type pubSubHubBubPayload struct {
diff --git a/github/repos_hooks.go b/github/repos_hooks.go
+//
+// GitHub API docs: https://developer.github.com/v3/repos/hooks/#subscribing
+type PubSubHubBubRequest struct {
+	HubMode     string `json:"hub_mode,omitempty"`
		// CreatePubSubHubBubrequest lets servers register receive updates when a topic is updated
		// using publish/subscribe protocol with GitHub as the hub for the repositories.
		// PubSubHubBubRequest represents the request to be send
		// for the GitHub's publish/subscribe hub protocol.
	type PubSubHubBubRequest struct {
	type PubSubHubbubRequest struct {
	type pubSubHubBubPayload struct {
	type pubSubHubbubPayload struct {
	func (s RepositoriesService) CreatePubSubHubBubRequest(ctx context.Context, request PubSubHubBubRequest) (*Response, error) {
	func (s RepositoriesService) CreatePubSubHubbubRequest(ctx context.Context, request PubSubHubbubRequest) (*Response, error) {

		hubTopic := fmt.Sprintf("/%v/%v/events/%v", request.HubTopic.Owner, request.HubTopic.Repo, request.HubTopic.Event)

		pubSubHubBubReq := &pubSubHubBubPayload{
	req, err := s.client.NewRequest("POST", u, pubSubHubBubReq)
	req, err := s.client.NewRequest("POST", u, pubSubHubbubReq)
	func TestRepositoriesService_TestPubSubHubBub(t *testing.T) {
	func TestRepositoriesService_TestPubSubHubbub(t *testing.T) {
	pubSubHubBubreq := &PubSubHubBubRequest{
	pubSubHubbubreq := &PubSubHubbubRequest{
	_, err := client.Repositories.CreatePubSubHubBubRequest(context.Background(), pubSubHubBubreq)
	_, err := client.Repositories.CreatePubSubHubbubRequest(context.Background(), pubSubHubbubreq)