Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
add ability to get the list of associated PRs for commit #987
Conversation
dmitrykiselev27
force-pushed the
dmitrykiselev27:associated_prs
branch
from
7a4d025
to
a901bce
|
This looks good! I think there's a missing unit test though. If you add that in I think this will be good to go! |
|
Oh and you'll need to add yourself as an author. See https://github.com/sigmavirus24/github3.py/blob/master/CONTRIBUTING.rst |
dmitrykiselev27
force-pushed the
dmitrykiselev27:associated_prs
branch
from
a901bce
to
5f4d933
|
Build failed (third-party-check pipeline) integration testing on
|
dmitrykiselev27
force-pushed the
dmitrykiselev27:associated_prs
branch
from
5f4d933
to
77378b9
|
Build failed (third-party-check pipeline) integration testing on
|
| @@ -139,6 +144,24 @@ def comments(self, number=-1, etag=None): | |||
| url = self._build_url("comments", base_url=self._api) | |||
| return self._iter(int(number), url, RepoComment, etag=etag) | |||
|
|
|||
| def associated_prs(self): | |||
sigmavirus24
Aug 19, 2020
Owner
I'm pretty sure we always want to ensure the user can pass a number here. Even if we can't pass that to the API, we can provide that functionality and this would be one odd method out.
Further, we prefer full names, so this should be associated_pull_requests
I'm pretty sure we always want to ensure the user can pass a number here. Even if we can't pass that to the API, we can provide that functionality and this would be one odd method out.
Further, we prefer full names, so this should be associated_pull_requests
dmitrykiselev27
force-pushed the
dmitrykiselev27:associated_prs
branch
from
77378b9
to
5db011b
|
Build failed (third-party-check pipeline) integration testing on
|
|
@omgjlk @sigmavirus24 thanks for the feedback. |
|
I'm happy to merge this. Would you be willing to fix the issues in CI around linting? |
use application/vnd.github.groot-preview+json request header to get the list of associated PRs for commit because the endpoint is in preview
dmitrykiselev27
force-pushed the
dmitrykiselev27:associated_prs
branch
from
5db011b
to
94d76e3
|
Build failed (third-party-check pipeline) integration testing on
|
Use application/vnd.github.groot-preview+json request header to get the list of associated PRs for commit because the endpoint is in preview