Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate default bodyType of Issue/Comments and Repository/Comments #551
Conversation
…figure methods The default value for these are incorrect per the GitHub API documentation https://developer.github.com/v3/media/#comment-body-properties
|
Thank you. I agree with this change because it aligns with the documentation and is consistent with the rest of the library. But as you say, this is a BC break and should be done prior 3.0 release. If not @cursedcoder argues that this is a bugfix I suggest leaving this PR open until 3.0 is getting closer. |
|
This needs rebasing. :) |
|
Maybe we should make the user specify what they want, and deprecate not specifying what you want in 2.x? |
|
Sorry, I merged without thinking instead of rebase. I can nuke this PR and recreate since this is a nothing change. Or if there is a way for me to fix this up, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bobeagan commentedMar 27, 2017
The default value for these configure methods are incorrect per the GitHub API documentation
https://developer.github.com/v3/media/#comment-body-properties
Submitted for consideration with the 3.0 release