Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChecking for nil response before closing it. #1601
Conversation
google-cla
bot
commented
Aug 13, 2020
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
google-cla
bot
commented
Aug 13, 2020
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
Reformatted the code.
google-cla
bot
commented
Aug 13, 2020
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
codecov
bot
commented
Aug 13, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
=======================================
Coverage 67.98% 67.99%
=======================================
Files 96 96
Lines 8772 8773 +1
=======================================
+ Hits 5964 5965 +1
Misses 1898 1898
Partials 910 910
Continue to review full report at Codecov.
|
|
@googlebot I signed it! |
|
Thank you, @kingbhanu ! |
kingbhanu commentedAug 13, 2020
Closing nil response will throw a panic so added a nil check before calling accessing resp object, defer function will be called even if there will be an error in response.