Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto named factory #1198

Open
AlexHladin opened this issue Mar 18, 2020 · 0 comments
Open

Add auto named factory #1198

AlexHladin opened this issue Mar 18, 2020 · 0 comments

Comments

@AlexHladin
Copy link

@AlexHladin AlexHladin commented Mar 18, 2020

Expected Behavior

Auto named factory functionality allows skipping the next code boilerplate code:

container.bind<interfaces.Factory<ServiceHandler>>("Factory<Elements>")
  .toFactory<ServiceHandler>((context: interfaces.Context) => (name: string) => {
    return context.container.getNamed<ServiceHandler>("Factory<Elements>", name)
  })

Current Behavior

Current behaviour forces to duplicate the same factories for different types.
Code above will be the same for a factory that produces elements and for a factory that produces components.

Possible Solution

A possible solution is creating toAutoNamedFactory method in container. I've created PR where I implemented this solution. You can review it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.