fix(reorder-group) : Adaptation when it is contained in a component#21747
Closed
Gwe-n wants to merge 1 commit intoionic-team:mainfrom
Closed
fix(reorder-group) : Adaptation when it is contained in a component#21747Gwe-n wants to merge 1 commit intoionic-team:mainfrom
Gwe-n wants to merge 1 commit intoionic-team:mainfrom
Conversation
Contributor
|
Thanks for the PR and apologies for the delay. We appreciate all the work you put into creating this PR. We are interested in accepting this fix, but we would like to sync the change with the latest code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19447
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19447
What is the new behavior?
The
OnStartfunction of the componentreorder-group.tsxhas been adapted to handlethe case where the "ion-item" is contained in a Custom Component.Does this introduce a breaking change?
Other information