Codecov Report

Merging #1317 into master will decrease coverage by 0.01%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   99.69%   99.67%   -0.02%     
==========================================
  Files         106      106              
  Lines       13008    13042      +34     
  Branches      996      998       +2     
==========================================
+ Hits        12968    13000      +32     
- Misses         23       25       +2     
  Partials       17       17

I think it's unnecessary to have a separate task_raised instrument to capture tasks exiting with exceptions, when you can just define a task_exited instrument that checks whether its outcome argument is an Error.

It looks like you're also calling task_raised when an exception is raised out of the nested child of a nursery. That's a functionality that's not currently exposed to the Instrument API -- maybe this PR could provide just that, under a more specific name like nested_child_exited?

Fair enough, thanks for the feedback. Fixed.

Umm, Azure seems not to have picked up the latest change ?

you can just define a task_exited instrument that checks whether its outcome argument is an Error.

… except that we don't have that yet.

@njsmith OK to simply add an outcome or exception argument to the task_exited instrumentation? Otherwise we'd need deprecation and a new method and all that.

… or I could simply set task.outcome=outcome before calling task_exited …

Ah, for some reason I thought we already passed the final outcome to the instrument... my bad!

I'm going to defer to @njsmith on the backwards compatibility policy for instruments.