add adaptive-expression library#1238
Conversation
|
@feich-ms Thanks! We'll take a closer look as soon as we can. One thing to note is that there is some refactoring planned in the dotnet repo for this package. |
|
@tracyboehrer Thank you very much, I'm still working on adding more expression functions and helpers, but this PR is already a minimun working version with fundamental components. Besides, Is the refactoring work you mentioned above related with this one microsoft/botbuilder-dotnet#4222? If so, I already aligned with this. If not, could you point me the right one? |
|
@feich-ms can you fix the CI failure? |
…otbuilder-python into feich/initExpression
|
@boydc2014 sure, CI failures are caused by code style checking and are fixed now. All checks passed now. |
Add conversions function for adaptive-expressions
feich-ms
changed the title
* implement regular expression * add bad expression testcase
* implement regular expression * add bad expression testcase * correct format of datetime for python
|
@vishwacsena, this PR is completely ready now. Functions and tests are fully aligned with C# and JS except the locale-aware ones(locale-aware functions are not much helpful in python library since python library is mainly used by adaptive card team now. We can of course add them when we are at that stage). Please help to prioritize the PR process if it's high. |
|
@sgellock @cleemullins can we take this for R11? Adaptive cards team had a customer who was looking for this and in general gets us well on the way to get to parity across languages. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fix formatDateTime function with "dd/MM/yyy" produces wrong results
|
This PR is 206 files and very complex. Please break this down into smaller, focused PRs, and we can review each one individually. |
|
I'd like to re-evaluate if this is still a pressing customer ask, regardless of the PR challenges Chris bring up. |
|
@clearab per I message I sent, can we prioritize the need and urgency? |
9 participants
This PR is to add adaptive expression library in python SDK. Functions and tests are fully aligned with C# and JS version. We can do an official R11 release after reviewed and approved.
Function list: