Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reporting of negated matchers for compound data #971

Open
jgebal opened this issue Jul 8, 2019 · 0 comments
Open

Improve reporting of negated matchers for compound data #971

jgebal opened this issue Jul 8, 2019 · 0 comments
Labels

Comments

@jgebal
Copy link
Member

@jgebal jgebal commented Jul 8, 2019

Current state

When running matchers for compound (diff-able) data-types, we currently report actual and expected data only.

No diff information is available when running not_to_equal and not_to_contain

Ideal state

When running not_to_equal the report could state:

Actual: refcursor [ count = 10 ] was expected not to equal: refcursor [ count = 4 ]
But all the rows are equal
   [ ... rows from actual go here, as both sides are equal ... ]

When running not_to_contain the report could state:

Actual: refcursor [ count = 10 ] was expected not to contain: refcursor [ count = 4 ]
But it contained:
   [ ... rows from actual that match the expected go here, to show rows that are not meeting the criteria ... ]

In both cases, when using join_by we could probably limit the outcomes to join_by columns as those would be sufficient to indicate the issue.

@jgebal jgebal added the enhancement label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.