Skip to content

Update release-checklist.md#777

Merged
agraebe merged 3 commits into
masterfrom
agraebe-release-update
Mar 26, 2020
Merged

Update release-checklist.md#777
agraebe merged 3 commits into
masterfrom
agraebe-release-update

Conversation

@agraebe
Copy link
Copy Markdown
Contributor

@agraebe agraebe commented Mar 25, 2020

Description

Adding todo to update community through email/discord/slack. This will allow broader community awareness for updates.

Jenny and Mitchell are aware of and approved this addition. They also suggested to provide more lead time for high impact release and engage with them earlier on to craft a more comprehensive community update.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other: Release Checklist

Does this introduce a breaking change?

No

Are documentation updates required?

No

Adding todo to update community through email/discord/slack
@agraebe agraebe requested a review from yknl March 25, 2020 21:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2020

Codecov Report

Merging #777 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files          64       64           
  Lines        3831     3831           
  Branches      701      701           
=======================================
  Hits         2634     2634           
  Misses        866      866           
  Partials      331      331           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336476f...9eb7042. Read the comment docs.

Comment thread release-checklist.md Outdated
- [ ] `git branch -D master-test`
- [ ] `git push origin :master-test`
- [ ] Announce availability in #engineering and on the forum here: https://forum.blockstack.org/c/releases (Include a link to the changelog)
- [ ] Announce availability to the community via Jenny Mith <jenny@blockstack.com> and Mitchell Cuevas <mitchell@blockstack.com>. Provide a succinct list of changes, the like to the changelog and latest release as well as a desired date for the community update.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "the link to the changelog" instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a link is not sufficient enough. They want two things mainly: 1) a date when this should go out to the community and 2) a message that should go out to the community. Just providing a link to the changelog won't be enough. We should clearly community in brief why and what was changed as well as what the impact is. It's something that will be really hard for Jenny or Mitchell to get from the pure technical changelog is my argument.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only referring to the spelling error: "like" in place of "link". Otherwise looks good to me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, of course, that needs to be fixed :)

Comment thread release-checklist.md Outdated
- [ ] `git branch -D master-test`
- [ ] `git push origin :master-test`
- [ ] Announce availability in #engineering and on the forum here: https://forum.blockstack.org/c/releases (Include a link to the changelog)
- [ ] Announce availability to the community via Jenny Mith <jenny@blockstack.com> and Mitchell Cuevas <mitchell@blockstack.com>. Provide a succinct list of changes, the like to the changelog and latest release as well as a desired date for the community update. Consider doing an AMA with the community.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the AMA meant to happen for every release?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, optional. I think this would require a judgement call on the releaser, ie "is this important enough to organize an AMA for"? Should I point that out as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be clear when that should happen. i.e. Consider doing an AMA on major/breaking releases.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, adding that

@agraebe agraebe requested a review from yknl March 26, 2020 14:58
Copy link
Copy Markdown
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agraebe agraebe merged commit 6ec6ebc into master Mar 26, 2020
@agraebe agraebe deleted the agraebe-release-update branch March 26, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants