Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate dependencies #246
Open
Update dependencies #246
Conversation
davidbailey00
changed the title
|
Thanks for your PR! Could you please revert the change on the |
| }, | ||
| "dependencies": { | ||
| "@jupyter-widgets/base": "^2 || ^3" |
ianhi
Jul 16, 2020
Contributor
I think that the ^2 || ^3 is what allows simultaneous support of jupyterlab 1 and 2.
I think that the ^2 || ^3 is what allows simultaneous support of jupyterlab 1 and 2.
ianhi
Jul 16, 2020
Contributor
oh wow. i sure didn't see the other comment already saying as much before i wrote that...
oh wow. i sure didn't see the other comment already saying as much before i wrote that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Update dependencies to latest versions, notably:
eslintv6 to v7 - none of the breaking changes affect the current setup of this projectrimrafv2 to v3 - drops support for Node.js 6 and olderstyle-loaderv0 to v1 - none of the breaking changes affect the current setup of this project@jupyter-widgets/basev2 to v3 - only dependency updates as far as I can tell (considering changes in thepackages/basedirectory)fs-extrav4 to v9 - various breaking changes which are mostly bugfixes, notably Node.js v10+ is requiredThis seems to also fix #238 so may be worth closing #245 if this is correct - I think the newest version of
@jupyter-widgets/baseseems to inject stylesheets in the correct order consistently