Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor webpack file #22

Merged
merged 1 commit into from Jul 6, 2018
Merged

Refactor webpack file #22

merged 1 commit into from Jul 6, 2018

Conversation

@pmargreff
Copy link
Contributor

@pmargreff pmargreff commented Jul 2, 2018

* Refactor webpack to only extends current webpack file from
ionic with purpose to not touch modules which persistence
does not need update. So all others modules than plugin could
be updated according ionic cycle.
	* Refactor webpack to only extends current webpack file from
	ionic with purpose to not touch modules which persistence
	does not need update. So all others modules than plugin could
	be updated according ionic cycle.
@pmargreff
Copy link
Contributor Author

@pmargreff pmargreff commented Jul 2, 2018

I remember about possible improvement on webpack file after seeing this answer on SO and how other project updates the webpack to not be so dependent and could enjoy new ionic functionalities on the fly ...

I tried to concatenate the typeorm packages, but didn't succeed with += either with .concat, so, suggestions are welcome.

@daniel-lang daniel-lang merged commit 7bd88df into typeorm:master Jul 6, 2018
@daniel-lang
Copy link
Contributor

@daniel-lang daniel-lang commented Jul 6, 2018

Thank you! This is something I have been looking into as well but didn't find the time to do. Makes the config file a lot more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.