doc: use npm team for npm upgrades in collaborator guide #33999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/collaborators This could use some reviews. Seems like it would be pretty non-controversial. |
addaleax
approved these changes
Jun 23, 2020
Trott
added
the
author ready
Flarna
approved these changes
Jun 23, 2020
targos
approved these changes
Jun 23, 2020
jasnell
approved these changes
Jun 23, 2020
puzpuzpuz
approved these changes
Jun 23, 2020
Trott
added a commit
that referenced
this issue
Jun 23, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
|
Landed in 680d7a0 |
codebytere
pushed a commit
that referenced
this issue
Jun 27, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this issue
Jun 30, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
codebytere
pushed a commit
that referenced
this issue
Jul 10, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
codebytere
pushed a commit
that referenced
this issue
Jul 12, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this issue
Jul 14, 2020
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: #33999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The collaborator guide suggests pinging individuals about npm upgrades.
Change to pinging the npm team instead.
Ping @nodejs/npm @Fishrock123 @MylesBorins
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes