Skip to content
Permalink
Browse files
build: zlib build error on Windows on Arm
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: #33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richard-townsend-arm authored and codebytere committed Jun 18, 2020
1 parent fc03224 commit 3ac05b75cad90e0b1ddda80c0b8c0b0eb864f1e5
Showing with 7 additions and 1 deletion.
  1. +7 −1 tools/v8_gypfiles/v8.gyp
@@ -1650,7 +1650,13 @@
'toolsets': ['host', 'target'],
}],
['OS=="win"', {
'defines': ['X86_WINDOWS'],
'conditions': [
['"<(target_arch)"=="arm64" and _toolset=="target"', {
'defines': ['CPU_NO_SIMD']
}, {
'defines': ['X86_WINDOWS']
}]
]
}],
],
'direct_dependent_settings': {

0 comments on commit 3ac05b7

Please sign in to comment.