inspector: drop 'chrome-' from inspector url

It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: #33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
nodejs · Jul 10, 2020 · 103a9af6736be99031806f590aeb05a59b9975d3 · 103a9af
1 parent 046dee6
commit 103a9af6736be99031806f590aeb05a59b9975d3
Showing with 1 addition and 1 deletion.

+1 −1 src/inspector_socket_server.cc
diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc
@@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket,
 std::string InspectorSocketServer::GetFrontendURL(bool is_compat,
     const std::string &formatted_address) {
   std::ostringstream frontend_url;
-  frontend_url << "chrome-devtools://devtools/bundled/";
+  frontend_url << "devtools://devtools/bundled/";
   frontend_url << (is_compat ? "inspector" : "js_app");
   frontend_url << ".html?experiments=true&v8only=true&ws=";
   frontend_url << formatted_address;