Skip to content

refactor(@angular-devkit/build-angular): improve budget warning messages#18159

Merged
filipesilva merged 1 commit into
angular:masterfrom
villelahdenvuo:patch-2
Aug 6, 2020
Merged

refactor(@angular-devkit/build-angular): improve budget warning messages#18159
filipesilva merged 1 commit into
angular:masterfrom
villelahdenvuo:patch-2

Conversation

@villelahdenvuo
Copy link
Copy Markdown
Contributor

@villelahdenvuo villelahdenvuo commented Jul 6, 2020

Visual Studio Code editor has nice link handling that allows one to easily open a file from the terminal output, however it doesn't work if the file path ends with a dot.

Here's a screenshot of the issue:
image

@villelahdenvuo
Copy link
Copy Markdown
Contributor Author

villelahdenvuo commented Jul 6, 2020

@alan-agius4 I made some improvements to the PR #17972 based on your comment, but I closed the old PR by accident so here's a new one.

@villelahdenvuo
Copy link
Copy Markdown
Contributor Author

@alan-agius4 hey, just dropping a comment so that the PR won't be automatically discarded. Have a nice one!

@alan-agius4
Copy link
Copy Markdown
Collaborator

@villelahdenvuo, thanks for the reminder.
Left a small comment about relative paths in errors.

@villelahdenvuo
Copy link
Copy Markdown
Contributor Author

@alan-agius4 Should be in order now, looks the CI failed on some missing package, though.

@alan-agius4
Copy link
Copy Markdown
Collaborator

@villelahdenvuo, there is currently an ongoing NPM issue https://status.npmjs.org/

Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 6, 2020
@alan-agius4
Copy link
Copy Markdown
Collaborator

@villelahdenvuo, just noticed that your commits are not squashed. Can you please squash them? Thanks.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 6, 2020
Make the warnings read more natural and work with vscode link detection.
@villelahdenvuo
Copy link
Copy Markdown
Contributor Author

@alan-agius4 I cleaned up the commits.

@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 6, 2020
@alan-agius4
Copy link
Copy Markdown
Collaborator

Thanks

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2020
@filipesilva filipesilva merged commit 8a10f2e into angular:master Aug 6, 2020
@villelahdenvuo villelahdenvuo deleted the patch-2 branch August 7, 2020 07:20
@villelahdenvuo
Copy link
Copy Markdown
Contributor Author

Thanks guys ✨

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants