Skip to content

feat: implementing multiple templates for Repeater#8684

Closed
CatchABus wants to merge 4 commits into
NativeScript:masterfrom
CatchABus:master
Closed

feat: implementing multiple templates for Repeater#8684
CatchABus wants to merge 4 commits into
NativeScript:masterfrom
CatchABus:master

Conversation

@CatchABus
Copy link
Copy Markdown
Contributor

@CatchABus CatchABus commented Jun 30, 2020 •
edited
Loading

PR Checklist

What is the current behavior?

Repeater does not support multiple templates.

What is the new behavior?

Repeater will support multiple templates using keys, just like ListView.

Implements #3781 .

This was tested carefully on android devices and no issues occured.

@cla-bot cla-bot Bot added the cla: yes label Jun 30, 2020
@NathanaelA

This comment was marked as abuse.

Sign in to view
@CatchABus
Copy link
Copy Markdown
Contributor Author

CatchABus commented Aug 27, 2020

@dimitrisrk - Can you re-target his to he new master repo please; looks like awesome new functionality!

@NathanaelA Thanks a lot for replying. Should I create a new PR based on new master branch then?
Thanks.

@NathanaelA

This comment was marked as abuse.

Sign in to view
@NathanWalker
Copy link
Copy Markdown
Contributor

NathanWalker commented Sep 7, 2020

@dimitrisrk I can probably help you here - perhaps a zoom chat in next week? If you're on {N} slack you can ping me there or shoot me email (which is widely publicly available 👍 ) We can look at any pending branch work you may have and help get ya settled.

@CatchABus
Copy link
Copy Markdown
Contributor Author

CatchABus commented Sep 9, 2020

@dimitrisrk I can probably help you here - perhaps a zoom chat in next week? If you're on {N} slack you can ping me there or shoot me email (which is widely publicly available 👍 ) We can look at any pending branch work you may have and help get ya settled.

That sounds great, but how about I attempted to adapt changes to NS7 first? This way, I won't be much of a bother. :))
I'm currently migrating my applications to NativeScript 7 (I really like these new changes) and trying to locate any possible issues. When done, I believe I can take another look at this.

@CatchABus CatchABus marked this pull request as draft October 22, 2020 07:53
@CatchABus CatchABus marked this pull request as ready for review October 22, 2020 18:45
@CatchABus
Copy link
Copy Markdown
Contributor Author

CatchABus commented Oct 22, 2020

I close this PR in favor of PR #8981

@CatchABus CatchABus closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CatchABus @NathanaelA @NathanWalker