Skip to content

fix: the css parser should handle empty nodes#8503

Merged
darind merged 1 commit into
masterfrom
darind/css-tree-parser-empty-nodes
Apr 6, 2020
Merged

fix: the css parser should handle empty nodes#8503
darind merged 1 commit into
masterfrom
darind/css-tree-parser-empty-nodes

Conversation

@darind
Copy link
Copy Markdown
Contributor

@darind darind commented Apr 5, 2020

PR Checklist

What is the current behavior?

The CSS parser is failing for empty rules such as:

Button.-primary {
    font-size: 18;
    ;
    color: red;
}

What is the new behavior?

The CSS parser should ignore such empty rules without failing.

@cla-bot cla-bot Bot added the cla: yes label Apr 5, 2020
Copy link
Copy Markdown
Contributor

@bundyo bundyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darind darind merged commit f7ab4ba into master Apr 6, 2020
@darind darind deleted the darind/css-tree-parser-empty-nodes branch April 6, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants