Skip to content

/ msgpack-ruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jruby MessagePack::Unpacker is loading all data from stream #138

Open
kirillrdy opened this issue Jul 2, 2017 · 0 comments
Open

jruby MessagePack::Unpacker is loading all data from stream #138

kirillrdy opened this issue Jul 2, 2017 · 0 comments

Comments

@kirillrdy
Copy link

@kirillrdy kirillrdy commented Jul 2, 2017

It looks like mri version of unpacker does buffered reads from the stream when given an io, but jruby version is loading all data from stream into memory.
Example code

file = File.new("some_large_file", "rb")
MessagePack::Unpacker.new(file) # in jruby reads all file here

I hope this finding at least helps someone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@kirillrdy
You can’t perform that action at this time.