Skip to content

/ msgpack-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "module" to package.json build for ES modules #103

Closed
JohnHardy opened this issue Feb 14, 2020 · 1 comment
Closed

Add "module" to package.json build for ES modules #103

JohnHardy opened this issue Feb 14, 2020 · 1 comment
Assignees
@gfx
Labels
Feature

Comments

@JohnHardy
Copy link

@JohnHardy JohnHardy commented Feb 14, 2020

Please would it be possible to add a module field in the package.json for an ES2019 bundle?

https://github.com/rollup/rollup/wiki/pkg.module

At the moment it seems like only browser and main are supported, targeting UMD and CommonJS respectively?

At the moment we are using rollup and the line that causes the trouble in bundling (using the commonJs() rollup plugin) is this one:

msgpack-javascript/src/utils/utf8.ts

Line 2 in c969bc9

process.env.TEXT_ENCODING !== "never" && typeof TextEncoder !== "undefined" && typeof TextDecoder !== "undefined";

@gfx gfx added the Feature label Feb 16, 2020
@gfx
Copy link
Member

@gfx gfx commented Feb 16, 2020

Thanks for the feature request. Sounds a good idea, so I'll do in the next few releases.
@gfx gfx self-assigned this Feb 16, 2020
@gfx gfx mentioned this issue Oct 4, 2020
Merged
@gfx gfx closed this in #137 Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfx gfx

Labels
Feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Provides ES modules by setting "module" field in package.json
2 participants
@gfx @JohnHardy
You can’t perform that action at this time.