Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: Don't test C extension on CPython 2.7 under Tox #406
Conversation
The py27-c variant is failing under Tox, with py27-c run-test-pre: PYTHONHASHSEED='1597877995' py27-c runtests: commands[0] | python -c 'from msgpack import _cmsgpack' Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: cannot import name _cmsgpack ERROR: InvocationError for command '/home/alex/src/msgpack-python/.tox/py27-c/bin/python -c from msgpack import _cmsgpack' (exited with code 1) As the Changelog notes, release 1.0 will drop support for the native extension on CPython 2.x. So there seems little benefit of testing it.
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 87.58% 87.94% +0.35%
==========================================
Files 5 5
Lines 846 846
==========================================
+ Hits 741 744 +3
+ Misses 105 102 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The py27-c variant is failing under Tox, with
As the Changelog notes, release 1.0 will drop support for the native
extension on CPython 2.x. So there seems little benefit of testing it.