Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate for Python 3.8 #374
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I believe these changes should be made to support Python 3.8.
I'm not sure if anything else should be changed, but I noticed there were a couple things that weren't updated to reference Python 3.8 in #371. I copied some changes from b8bf3c9, but I wasn't sure if 3.6 should be removed like 3.5 was in b1d658e.
From #371 it looks like xenial is being used and 3.8 wouldn't be there so I don't think I can remove the "-dev" suffix and I probably can't add 3.9 via "nightly". Looking the .travis.yml I think(?) 3.8 will be tested via the quay.io/pypa/manylinux1_i686 image.