Skip to content

/ prettier

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright line #5455

Merged
merged 3 commits into from Jan 3, 2019
Merged

Update copyright line #5455

merged 3 commits into from Jan 3, 2019

Conversation

@j-f1
Copy link
Member

@j-f1 j-f1 commented Nov 12, 2018

Since @jlongster isn’t as involved in the project and it’s now more of a community project, I’ve updated the license file to reflect these changes. I requested @jlongster’s review because I think he needs to approve this kind of license change.

✨Try the playground for this PR✨
@j-f1
Update copyright line
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dd0e1db
@j-f1 j-f1 requested review from jlongster and prettier/core Nov 12, 2018
@lipis
lipis approved these changes Nov 12, 2018
View changes
@j-f1 j-f1 mentioned this pull request Nov 12, 2018
Closed
@suchipi
suchipi approved these changes Nov 13, 2018
View changes
Copy link
Member

@suchipi suchipi left a comment

LGTM but I think legally James needs to approve it before it can be merged
@kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Nov 13, 2018

Is the current year necessary?

facebook/react folks were using yyyy-present, but recently dropped the year completely:
facebook/react@b87aabd
@j-f1
Copy link
Member Author

@j-f1 j-f1 commented Nov 28, 2018

Note to self: update freeCodeCamp/devdocs#936 when merged.
@j-f1
Update LICENSE
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dbe349a
@suchipi
Copy link
Member

@suchipi suchipi commented Nov 29, 2018

Woah, I didn't know about devdocs, that's cool
@lipis
Copy link
Member

@lipis lipis commented Dec 26, 2018

Hey @jlongster, have you seen this?
@jlongster
jlongster approved these changes Jan 2, 2019
View changes
Copy link
Member

@jlongster jlongster left a comment

So sorry! I don't check github these days, and even after being pinged about it I put it up on my todo list and then holidays & kids knocked me out. Anyway, this looks fine, thanks!
@existentialism
existentialism approved these changes Jan 3, 2019
View changes
@ikatyang
Merge branch 'master' into update-copyright
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc7bea7
@ikatyang
ikatyang approved these changes Jan 3, 2019
View changes
@j-f1
Copy link
Member Author

@j-f1 j-f1 commented Jan 3, 2019

Awesome, thanks @jlongster!
@j-f1 j-f1 merged commit 633a12a into prettier:master Jan 3, 2019
8 checks passed
8 checks passed
Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch Coverage not affected when comparing 1ca4731...fc7bea7
Details
codecov/project 94.38% remains the same compared to 1ca4731
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20190103.1 succeeded
Details
@brodybits brodybits mentioned this pull request Jan 3, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlongster jlongster

@existentialism existentialism

@lipis lipis

@suchipi suchipi

@ikatyang ikatyang

Assignees
No one assigned
Labels
locked-due-to-inactivity
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@j-f1 @kachkaev @suchipi @lipis @jlongster @existentialism @ikatyang
You can’t perform that action at this time.