Skip to content

/ matplotlib Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle 'none' facecolors in do_3d_projection #18060

Closed
wants to merge 1 commit into from
Closed

Correctly handle 'none' facecolors in do_3d_projection #18060

wants to merge 1 commit into from

Conversation

@dstansby
Copy link
Member

@dstansby dstansby commented Jul 25, 2020

Fixes #18020.

Changes made in #17543 meant that _facecolor3d can now be an empty array, therefore make sure do_3d_projection only handles the case where the facecolor is set.
@dstansby
Only handle len > 0 facecolors in do_3d_projection
4d60247
@dstansby dstansby changed the title Only handle len > 0 facecolors in do_3d_projection Correctly handle 'none' facecolors in do_3d_projection Jul 25, 2020
@dstansby dstansby added this to the v3.3.1 milestone Jul 25, 2020
timhoffm
timhoffm approved these changes Jul 25, 2020
View changes
@tacaswell
Copy link
Member

@tacaswell tacaswell commented Jul 28, 2020

We might not have to backport this given that #17861 reverted the changes on v3.3.x?

@tacaswell
Copy link
Member

@tacaswell tacaswell commented Jul 28, 2020

#17850 is also relevant here?

@dstansby dstansby removed this from the v3.3.1 milestone Jul 30, 2020
@dstansby dstansby added this to the v3.4.0 milestone Jul 30, 2020
@dstansby
Copy link
Member Author

@dstansby dstansby commented Jul 30, 2020

  • Agreed that this doesn't need backporting any more
  • It looks like if #17850 is merged the code changes here are redundant, but the test should probably still go in

@jklymak jklymak marked this pull request as draft Aug 24, 2020
@jklymak jklymak removed this from the v3.4.0 milestone Jan 27, 2021
@jklymak jklymak added this to the v3.4.1 milestone Jan 27, 2021
@QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 19, 2021

#17850 was merged, so it looks like this needs to be changed to only include the test.

@QuLogic QuLogic removed this from the v3.4.1 milestone Mar 30, 2021
@QuLogic QuLogic added this to the v3.4.2 milestone Mar 30, 2021
@dstansby
Copy link
Member Author

@dstansby dstansby commented Apr 4, 2021

Looks like #18020 is closed, so I'm going to close this too.

@dstansby dstansby closed this Apr 4, 2021
@QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 6, 2021

Did you not want to keep the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm

Assignees
No one assigned
Labels
status: needs rebase status: needs revision status: waiting for other PR topic: mplot3d
Projects
None yet
Milestone
v3.4.2
Linked issues

Successfully merging this pull request may close these issues.

Scatter3D: facecolor or color to "none" leads to an error
5 participants
@dstansby @tacaswell @QuLogic @timhoffm @jklymak