Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whether ORB_SLAM3 would support the ROS #1

Open
Sunchanghao opened this issue Jul 24, 2020 · 16 comments
Open

whether ORB_SLAM3 would support the ROS #1

Sunchanghao opened this issue Jul 24, 2020 · 16 comments

Comments

@Sunchanghao
Copy link

@Sunchanghao Sunchanghao commented Jul 24, 2020

looking forward to!

@saimouli
Copy link

@saimouli saimouli commented Jul 24, 2020

@dimaxano
Copy link

@dimaxano dimaxano commented Jul 24, 2020

As I see this code uses ORB_SLAM2 class, not ORB_SLAM3.

@SteveMacenski
Copy link

@SteveMacenski SteveMacenski commented Jul 24, 2020

Also support for ROS2 (I'm maintainer on ROS2 navigation2, would love to do testing with this!) would be great. I'd like to make formally supported integrations with this and ROS2 with navigation2 (https://github.com/ros-planning/navigation2).

I see a few ORB-SLAM2 references that weren't changed: https://github.com/UZ-SLAMLab/ORB_SLAM3/search?p=1&q=ORB_SLAM2&unscoped_q=ORB_SLAM2

Do you intend to support this and improve on it or is this a one-and-done research project? I ask because if we do some integrations with navigation2 we'll likely make improvements and want to know if we should fork this for the ROS world or submit PRs back here if there's support.

@mirellameelo
Copy link

@mirellameelo mirellameelo commented Jul 24, 2020

+1

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 25, 2020

As I see this code uses ORB_SLAM2 class, not ORB_SLAM3.

Have you tested the effect?

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 25, 2020

Also support for ROS2 (I'm maintainer on ROS2 navigation2, would love to do testing with this!) would be great. I'd like to make formally supported integrations with this and ROS2 with navigation2 (https://github.com/ros-planning/navigation2).

I see a few ORB-SLAM2 references that weren't changed: https://github.com/UZ-SLAMLab/ORB_SLAM3/search?p=1&q=ORB_SLAM2&unscoped_q=ORB_SLAM2

Do you intend to support this and improve on it or is this a one-and-done research project? I ask because if we do some integrations with navigation2 we'll likely make improvements and want to know if we should fork this for the ROS world or submit PRs back here if there's support.

good job!
therefor, the interface in the current vision is ORB_SLAM2?

@zhijianglu
Copy link

@zhijianglu zhijianglu commented Jul 25, 2020

just change ORBSLAM2::System into ORBSLAM3::System, I can compile the code by catkin_make

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 25, 2020

just change ORBSLAM2::System into ORBSLAM3::System, I can compile the code by catkin_make

哈 那效果呢 是新版本的效果了吧 不知道会不会有什么问题

@liuzhenboo
Copy link

@liuzhenboo liuzhenboo commented Jul 26, 2020

ros代码里面的那些命名空间还是ORBSLAM2

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 26, 2020

ros代码里面的那些命名空间还是ORBSLAM2

是啊 所以不知道啥意思

@liuzhenboo
Copy link

@liuzhenboo liuzhenboo commented Jul 26, 2020

ORBSLAM3 haven't provide source code of vio based ros.

@liuzhenboo
Copy link

@liuzhenboo liuzhenboo commented Jul 26, 2020

关于VIO的ros代码作者没有提供;不过由于兼容了ORBSLAM2的一些函数,所以orbslam3中基于ros的视觉里程计代码理论上还是能跑的,不过要改一些变量名,命名空间杀啥的。。

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 26, 2020

关于VIO的ros代码作者没有提供;不过由于兼容了ORBSLAM2的一些函数,所以orbslam3中基于ros的视觉里程计代码理论上还是能跑的,不过要改一些变量名,命名空间杀啥的。。

好的吧 再等等先

@zang09
Copy link

@zang09 zang09 commented Jul 27, 2020

I change the code 'ORBSLAM2' to 'ORBSLAM3' and success build and launch.
But there is no mono-inertial or stereo-inertial code in Example/ROS

@Sunchanghao
Copy link
Author

@Sunchanghao Sunchanghao commented Jul 27, 2020

I change the code 'ORBSLAM2' to 'ORBSLAM3' and success build and launch.
But there is no mono-inertial or stereo-inertial code in Example/ROS

There also seems to be no odometer~

@xiefei2929
Copy link

@xiefei2929 xiefei2929 commented Jul 27, 2020

I commited two visual-inertial ROS interfaces Mono_inertial and Stereo_inertial at https://github.com/xiefei2929/ORB_SLAM3-ROS-Interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.