Update messaging.md#2553
Merged
Merged
Conversation
Add warning missmatch firebase version could lead unable to get notification
brianseim
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Updating the documentation:
Because of this issue comment, I see that we unable to receive messaging if we have different
firebaseversion infirebase-messaging-sw.jsrefer to:
#2299 (comment) #2299 (comment)
#1904 (comment)
And this issue #1904 (comment) have quote:
solution was confirmed in stackoverflow:
https://stackoverflow.com/questions/40411059/create-firebase-notification-with-page-in-foreground-focus
https://stackoverflow.com/questions/58279900/angular-7-cannot-receive-firebase-notification-in-the-foreground
https://stackoverflow.com/questions/58386934/web-firebase-messaging-onmessage-not-fired-but-background-notification-perfec
So, we need have an example and warning developer to keep it up to date with
firebaseinpackage.jsonCode sample
quick view to preview md is here: PR preview docs