Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular ivy #19515

Merged
merged 29 commits into from Dec 18, 2019
Merged

Angular ivy #19515

merged 29 commits into from Dec 18, 2019

Conversation

@mhartington
Copy link
Member

@mhartington mhartington commented Oct 1, 2019

No description provided.

@dylanvdmerwe
dylanvdmerwe reviewed Oct 7, 2019
View changes
angular/src/directives/navigation/ion-back-button.ts Outdated Show resolved Hide resolved
@mhartington mhartington force-pushed the angular-ivy branch 2 times, most recently from eb906f1 to d52c215 Oct 31, 2019
@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Nov 13, 2019
@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Nov 13, 2019
mhartington added 13 commits Apr 3, 2019
@mhartington
init ivy support
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
6f443a2
@mhartington
chore(): angular prerelease
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
f207b36
@mhartington
chore: update
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
61dc271
@mhartington
updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
6356fa9
@mhartington
angular 8 deps
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
3a163ae
@mhartington
chore(angular): update sync script
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
74a8cc6
@mhartington
updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
7a57779
@mhartington
chore(): remove console log
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
e17ffeb
@mhartington
chore(): updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
86d633d
@mhartington
chore(): update release script
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
506a767
@mhartington
fix(): remove comments
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
97c2b40
@mhartington
fix(): remove test version
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
31b2250
@mhartington
fix(): failing angular test
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
030ced8
@mhartington mhartington force-pushed the angular-ivy branch from 648183f to 030ced8 Nov 13, 2019
mhartington added 4 commits Nov 15, 2019
@mhartington
fix(): failing angular tests
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
a6b1b38
@mhartington
fix(): update ci steps
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
b3d6cf1
@mhartington
fix(): fix sync script
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
302164b
@mhartington
chore(): refactor angular proxies
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
fed5508
@mhartington
Copy link
Member Author

@mhartington mhartington commented Nov 27, 2019

Needs ionic-team/stencil#2033 to be merged/resolved
@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 11, 2019

ionic-team/stencil#2033 has been merged, need a new pre-release for testing
mhartington added 3 commits Dec 13, 2019
@mhartington
chore(): updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
b9cc369
@mhartington
chore(): updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
ce2bb90
@mhartington
chore(): lint
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
1963548
mhartington and others added 3 commits Dec 13, 2019
@mhartington
Merge branch 'master' into angular-ivy
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
748048f
@mhartington
chore(): updates
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
d99b433
@adamdbradley
chore(ssr): check for window
Loading status checks…
96e613e
@mhartington mhartington mentioned this pull request Dec 16, 2019
Closed
4 of 13 tasks complete
@dennisameling dennisameling mentioned this pull request Dec 16, 2019
Closed
mhartington added 2 commits Dec 16, 2019
@mhartington
chore(): fix virtual scroll angular tests
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
35d2aab
@mhartington
chore(): lint
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
529d839
@vially
vially suggested changes Dec 16, 2019
View changes
.scripts/common.js Outdated Show resolved Hide resolved
@mhartington
chore(): add server to link
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
346c0a1
@brandyscarney
brandyscarney requested changes Dec 17, 2019
View changes
.scripts/common.js Outdated Show resolved Hide resolved
.scripts/common.js Outdated Show resolved Hide resolved
.scripts/common.js Outdated Show resolved Hide resolved
@brandyscarney
chore(scripts): update release script
Loading status checks…
2473b86
@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 18, 2019

I updated the release script to fix some of my comments. The only outstanding comment is related to the order of updating the core dependencies and running npm link. This may cause issues, I want to say that's why they were separate.

Overall testing of the dev build seems to be going well, so that's my only concern!
mhartington and others added 2 commits Dec 18, 2019
@mhartington
chore(): bump version check
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
Loading status checks…
3379f35
@brandyscarney
style(scripts): spacing
Loading status checks…
52bc7a5
@brandyscarney
brandyscarney approved these changes Dec 18, 2019
View changes
@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 18, 2019

:shipit:
@mhartington mhartington merged commit 2344d0b into master Dec 18, 2019
1 check failed
1 check failed
build Workflow: build
Details
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Dec 18, 2019
@SchnWalter
SchnWalter reviewed Dec 19, 2019
View changes
angular/src/directives/proxies-utils.ts Show resolved Hide resolved
@brandyscarney brandyscarney deleted the angular-ivy branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vially vially

@SchnWalter SchnWalter

@dylanvdmerwe dylanvdmerwe

@brandyscarney brandyscarney

Assignees
No one assigned
Labels
package: angular package: core
Projects
Ionic Core
  
Done 🎉
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mhartington @brandyscarney @vially @SchnWalter @dylanvdmerwe @adamdbradley
You can’t perform that action at this time.