Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate checks in pummel/test-timers #34473

Merged
merged 0 commits into from Jul 24, 2020

Conversation

Copy link
Member

@Trott Trott commented Jul 22, 2020

Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Jul 22, 2020
Copy link

@MrHeer MrHeer left a comment

LGTM

@Trott
Copy link
Member Author

@Trott Trott commented Jul 22, 2020

@Trott Trott added the author ready label Jul 22, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Jul 24, 2020

Landed in 986ae1e

@Trott Trott closed this Jul 24, 2020
@Trott Trott merged commit 986ae1e into nodejs:master Jul 24, 2020
@Trott Trott deleted the remove-duplicate branch Jul 24, 2020
MylesBorins pushed a commit that referenced this issue Jul 27, 2020
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this issue Sep 22, 2020
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants