Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix @bazel/bazel to bazelisk leftovers #36132

Closed
wants to merge 1 commit into from
Closed

build: fix @bazel/bazel to bazelisk leftovers #36132

wants to merge 1 commit into from

Conversation

@devversion
Copy link
Member

devversion commented Mar 18, 2020 •
edited

Follow-up for #36078. A few leftovers from from @bazel/bazel to
@bazel/bazelisk migration are still there. This commit fixes those, so
that the repository no longer relies on @bazel/bazel.
@devversion
build: fix @bazel/bazel to bazelisk leftovers
Loading status checks…
d588761 
A few leftovers from from `@bazel/bazel` to `@bazel/bazelisk` migration
are still there. This commit fixes those, so that the repository no
longer relies on `@bazel/bazel`.
@googlebot googlebot added the cla: yes label Mar 18, 2020
@pullapprove pullapprove bot requested a review from IgorMinar Mar 18, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 18, 2020
@devversion
devversion reviewed Mar 18, 2020
View changes
scripts/release/publish-latest
# through `yarn bazel` causes additional output that throws off the command stdout.
BAZEL_BIN=$(yarn bin)/bazel
# through `yarn bazelisk` causes additional output that throws off the command stdout.
BAZEL_BIN=$(yarn bin)/bazelisk

This comment has been minimized.

Sign in to view
Copy link
@devversion

devversion Mar 18, 2020 •
edited

Author Member

I considered switching this to yarn --silent bazel (to fix the stdout capturing and to consistently use yarn bazel), but decided to keep it as is.

Mostly because bazel query <..> kind("ng_package|pkg_npm", //packages/...) breaks on Windows unexpectedly with yarn --silent bazel.
@devversion devversion requested a review from josephperrott Mar 19, 2020
@josephperrott
josephperrott approved these changes Mar 19, 2020
View changes
Copy link
Member

josephperrott left a comment

LGTM
@josephperrott josephperrott removed the request for review from IgorMinar Mar 19, 2020
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 19, 2020

Hi @IgorMinar, as we discussed yesterday, you had some feedback about the changes in this PR (related to using yarn with bazelisk), but in order to get release unblocked, I've merged this PR in its current state. Let's create a followup PR once you provide the feedback. Thank you.
@devversion
Copy link
Member Author

devversion commented Mar 19, 2020

👍 Sounds good to me. Would love to get feedback on this. Note that I replied on why I intentionally didn't use yarn bazel (if that is related to the discussion you had yesterday)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 19, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott

Assignees

@IgorMinar IgorMinar

Labels
PR action: merge PR target: master-only cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@devversion @AndrewKushnir @josephperrott @IgorMinar @googlebot
You can’t perform that action at this time.