Skip to content

bpo-41228: Fix a typo in the description of monthcalendar()#21372

Merged
terryjreedy merged 3 commits intopython:masterfrom
nimadini:patch-1
Jul 11, 2020
Merged

bpo-41228: Fix a typo in the description of monthcalendar()#21372
terryjreedy merged 3 commits intopython:masterfrom
nimadini:patch-1

Conversation

@nimadini
Copy link
Contributor

@nimadini nimadini commented Jul 7, 2020 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jul 7, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nimadini

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 7, 2020
@nimadini nimadini changed the title Fix a typo in the description of monthcalendar() bpo-41228: Fix a typo in the description of monthcalendar() Jul 7, 2020
rhettinger
rhettinger previously requested changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No news entry is needed. Otherwise, it's fine. Thanks for the PR.

@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nimadini
Copy link
Contributor Author

nimadini commented Jul 7, 2020

I have made the requested changes; please review again. Thanks!

@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2020

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from rhettinger July 7, 2020 23:06
@terryjreedy terryjreedy merged commit 344dce3 into python:master Jul 11, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 11, 2020

Thanks @nimadini for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2020
@nimadini @miss-islington
bpo-41228: Fix /a/are/ in monthcalendar() descripton (pythonGH-21372)
f5b3442 
(cherry picked from commit 344dce3)

Co-authored-by: Nima Dini <nima.dini@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 11, 2020

GH-21440 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 11, 2020

GH-21441 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2020
@nimadini @miss-islington
bpo-41228: Fix /a/are/ in monthcalendar() descripton (pythonGH-21372)
bebad68 
(cherry picked from commit 344dce3)

Co-authored-by: Nima Dini <nima.dini@gmail.com>
miss-islington added a commit that referenced this pull request Jul 11, 2020
@miss-islington @nimadini
bpo-41228: Fix /a/are/ in monthcalendar() descripton (GH-21372)
a77b1f6 
(cherry picked from commit 344dce3)

Co-authored-by: Nima Dini <nima.dini@gmail.com>
miss-islington added a commit that referenced this pull request Jul 11, 2020
@miss-islington @nimadini
bpo-41228: Fix /a/are/ in monthcalendar() descripton (GH-21372)
c77f71f 
(cherry picked from commit 344dce3)

Co-authored-by: Nima Dini <nima.dini@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@nimadini @shihai1991
bpo-41228: Fix /a/are/ in monthcalendar() descripton (pythonGH-21372)
2a67b47
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@nimadini
bpo-41228: Fix /a/are/ in monthcalendar() descripton (pythonGH-21372)
27091d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nimadini @the-knights-who-say-ni @bedevere-bot @miss-islington @rhettinger @tirkarthi @terryjreedy

Comments