JS: Use local name resolution in TypeAnnotation.hasQualifiedName#3873
Merged
codeql-ci merged 6 commits intoSep 7, 2020
Conversation
asgerf
added
JS
Awaiting evaluation
erik-krogh
reviewed
Jul 6, 2020
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
LGTM.
You just have to update the expected files of a test.
asgerf
force-pushed
the
js/type-qualified-name-fallback
branch
from
15c4ed2 to
7a8b54b
Compare
erik-krogh
previously approved these changes
Aug 3, 2020
Contributor
Author
|
Smoke-test evaluation (internal link) looks fine. I'm considering rebasing on the RC branch, but will wait for next week. |
asgerf
removed
the
Awaiting evaluation
asgerf
force-pushed
the
js/type-qualified-name-fallback
branch
2 times, most recently
from
8099c88 to
c05f5c1
Compare
erik-krogh
reviewed
Sep 4, 2020
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
erik-krogh
previously approved these changes
Sep 4, 2020
erik-krogh
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizing type annotations by name can be a bit painful in cases where the type system fails to resolve it for some reason (mainly missing dependencies).
This makes
TypeAnnotation.hasQualifiedNameinclude names found through local name resolution, in addition to consulting the type system.There are not many cases where we get results from both the type system and from local resolution, but there is an example in kibana. Here it happens because the file is part of a package (kibana is a monorepo), so we get both the snapshot-relative path and the package-relative path, which I think is fine, as
hasQualifiedNamedoes not imply uniqueness.