Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTravis CI black --check #640
Open
Comments
|
Seems like the PR #551 put it in before_script simply because "It will not make every build (from this PR)" fail. Sometimes, for some repos, good style may make the meaning behind the code illegible, which may be the case here... However, I just strolled into this repo, so I can't give concreteness to that previous statement. Addressing the side note, the Tox env is already doing the testing with pytest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there a reason why in travis CI config the command
black --check . || trueis run? I don't see the point in checking if files needs to be reformatted if it's just going to be ignored anyways.Currently running
black --line-length 127 --check .->399 files would be reformatted, 74 files would be left unchanged.In addition running
flake8 . --count --show-source --statistics --max-line-length=127Yields 2496 errors which is reduced to 746 after reformatting usingblack --line-length 127 .As a side note it might be a good idea to run pytest/doctest/unittest here too to make sure tests are passing.