Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action workflow (x64) and Travis (arm64) build #524

Merged
merged 8 commits into from Jun 16, 2020

Conversation

@xerial
Copy link
Member

@xerial xerial commented Jun 16, 2020

xerial added 5 commits Jun 16, 2020
@xerial xerial changed the title Add GitHub Action workflow Add GitHub Action workflow (x64) and Travis (arm64) build Jun 16, 2020
xerial added 3 commits Jun 16, 2020
@xerial xerial requested a review from komamitsu Jun 16, 2020
Copy link

@yuokada yuokada left a comment

LGTM

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v7

This comment has been minimized.

@yuokada

yuokada Jun 16, 2020

If the AdoptJDK installation is supported in setup-java action, it's better to replace with it.
https://github.com/actions/setup-java

This comment has been minimized.

@xerial

xerial Jun 16, 2020
Author Member

msgpack-java's test is written in Scala, and also setup-scala can install natively-built sbt (csbt) using GraalVM. So let me keep using setup-scala.

with:
path: ~/.cache
key: ${{ runner.os }}-jdk11-${{ hashFiles('**/*.sbt') }}
restore-keys: ${{ runner.os }}-jdk11-

This comment has been minimized.

@yuokada

yuokada Jun 16, 2020

Is this key correct?

This comment has been minimized.

@xerial

xerial Jun 16, 2020
Author Member

Yes. It has fallback mechanism https://github.com/actions/cache#inputs (fixed the link)

This comment has been minimized.

@yuokada

yuokada Jun 16, 2020

I read below document after I wrote above comment. And though I understood the specification of restore-keys, I forgot removing it.
https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows

@xerial xerial merged commit 981c9c7 into develop Jun 16, 2020
4 checks passed
4 checks passed
Code Format
Details
Test JDK11
Details
Test JDK8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xerial xerial deleted the github-actions branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.