Skip to content

/ pyrogram

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for uploading from file pointers #286

Closed
wants to merge 10 commits into from
Closed

Add support for uploading from file pointers #286

wants to merge 10 commits into from

Conversation

@OctoNezd
Copy link
Contributor

@OctoNezd OctoNezd commented Jul 20, 2019 •
edited

Fixes #261
image

All file pointers must have attribute .name

Tested methods:

  • send_animated_sticker
  • send_animation
  • send_audio
  • send_document
  • send_photo
  • send_sticker
  • send_video
  • send_video_note
  • send_voice
OctoNezd added 7 commits Jul 20, 2019
@OctoNezd
Add support for downloading files to file pointer, fix for #284
78542ee
@OctoNezd
Add support for uploading from file pointers, fixes #261
b184b10
@OctoNezd
Annotate file-like objects in docstring of send_document
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
95b9df6
@OctoNezd
Annotate file-like objects in docstring of send_sticker
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4dbba0a
@OctoNezd
Annotate file-like objects in docstring of send_video
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
96b72f4
@OctoNezd
Merge branch 'in-memory-downloads' into in_memory_uploads
e717b9c
@OctoNezd
Fix TypeError in send_sticker
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a38924e
@OctoNezd
Copy link
Contributor Author

@OctoNezd OctoNezd commented Jul 20, 2019

Can someone test other methods?
@OctoNezd
Merge branch 'in_memory_uploads' of https://github.com/OctoNezd/pyrogram
458a773 
 into in_memory_uploads
@AyraHikari
Copy link

@AyraHikari AyraHikari commented Aug 2, 2019 •
edited

All test passed, except for send_voice

  • send_animated_sticker
  • send_animation
  • send_audio
  • send_photo
  • send_video
  • send_video_note
  • send_voice

client.send_voice(c, open("voice.ogg", "rb"))

ERROR:pyrogram.client.ext.dispatcher:'str' object has no attribute 'write'
Traceback (most recent call last):
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/client/ext/dispatcher.py", line 178, in update_worker
    handler.callback(self.client, *args)
  File "test.py", line 47, in starting_test
    client.send_voice(c, open("voice.ogg", "rb"))
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/client/methods/messages/send_voice.py", line 161, in send_voice
    **self.parser.parse(caption, parse_mode)
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/client/client.py", line 1087, in send
    r = self.session.send(data, retries, timeout)
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/session/session.py", line 437, in send
    return self._send(data, timeout=timeout)
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/session/session.py", line 403, in _send
    message = self.msg_factory(data)
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/session/internals/msg_factory.py", line 37, in __call__
    len(body)
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/api/core/tl_object.py", line 76, in __len__
    return len(self.write())
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/api/functions/messages/send_media.py", line 104, in write
    b.write(self.media.write())
  File "/home/ayra/.local/share/virtualenvs/test-jenOu_xj/lib/python3.7/site-packages/pyrogram/api/types/input_media_uploaded_document.py", line 84, in write
    b.write(self.file.write())
AttributeError: 'str' object has no attribute 'write'
@OctoNezd
Fix send_voice
1154830
@OctoNezd
Copy link
Contributor Author

@OctoNezd OctoNezd commented Aug 4, 2019 •
edited

Fixed send_voice
@delivrance
Merge remote-tracking branch 'upstream/develop' into in_memory_uploads
9220c21 
# Conflicts:
#	pyrogram/client/methods/messages/download_media.py
#	pyrogram/client/methods/messages/send_animated_sticker.py
@delivrance delivrance closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support for in-memory file uploads
3 participants
@OctoNezd @AyraHikari @delivrance
You can’t perform that action at this time.