Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the method return value when stepping out #336

Merged
merged 5 commits into from Jul 6, 2020

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Jun 23, 2020

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Close microsoft/vscode-java-debug#660

@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jun 23, 2020

image

@testforstephen testforstephen requested review from andxu, jdneo, Eskibear and akaroml Jun 23, 2020
@testforstephen testforstephen force-pushed the testforstephen:jinbo_methodreturn branch from 9695f6d to d2cffbd Jun 23, 2020
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen testforstephen force-pushed the testforstephen:jinbo_methodreturn branch from d2cffbd to ed3a3b1 Jul 1, 2020
@testforstephen testforstephen marked this pull request as ready for review Jul 1, 2020
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@jdneo
Copy link
Member

@jdneo jdneo commented Jul 1, 2020

What if the method has parameters? And what will it looks like when it's a invocation chain (like stream invocation)

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@Eskibear
Copy link
Member

@Eskibear Eskibear commented Jul 3, 2020

With this icon '⎯►', then why you still need to append "returned", for better clarification?

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jul 6, 2020

Addressed, below is the new look.
image

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@jdneo
jdneo approved these changes Jul 6, 2020
@testforstephen testforstephen merged commit bf689a6 into microsoft:master Jul 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the testforstephen:jinbo_methodreturn branch Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.