Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle slashes in Presto schemas for SQLAlchemy URL #280

Open
yciabaud opened this issue Apr 14, 2019 · 1 comment
Open

Handle slashes in Presto schemas for SQLAlchemy URL #280

yciabaud opened this issue Apr 14, 2019 · 1 comment

Comments

@yciabaud
Copy link

@yciabaud yciabaud commented Apr 14, 2019

When connecting a PrestoDB database to query a Apache Pulsar SQL worker, errors are occurring when working with a schema containing slashes.

The check from: https://github.com/dropbox/PyHive/blob/master/pyhive/sqlalchemy_presto.py#L106 is raising an exception whereas I expected the schema to contain the slash.

I believe the check should be removed or we need a way to escape the slashes:

  • presto://localhost:8081/pulsar/public/default
  • presto://localhost:8081/pulsar/public%2Fdefault

Example of integration can be found here: apache/superset#7297

@yciabaud yciabaud changed the title Handle slashes in Presto schemas Handle slashes in Presto schemas for SQLAlchemy URL Apr 14, 2019
@yciabaud
Copy link
Author

@yciabaud yciabaud commented Apr 14, 2019

A workaround for this is using presto://localhost:8081/pulsar?schema=public/default', if this is OK for you you can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant