Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I suggest to remove weird
echoflag because it's behavior is confusing. There is similar flag in SQLAlchemy for instance and it's behavior is the following: "if you don't want to setup your own logging, then specifyecho=Trueand library will add handler for internal logger which outputs logs automatically, but if you setup loggers manually, then you don't needechoflag and logging just works" (https://github.com/sqlalchemy/sqlalchemy/blob/4aadcca993ce30c25b09679178907991b4430b2e/lib/sqlalchemy/log.py#L94-L97).In case of
aiopgit's simply:aiopg/aiopg/cursor.py
Lines 109 to 111 in 57b5d55