NativeScript / NativeScript

Sponsor

Sponsor NativeScript/NativeScript
Watch 704
Star 19.2k
Fork 1.4k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundle): support for file qualifiers + builder refactor #7386

Merged

manoldonev merged 14 commits into master from builder-refactor

Jun 26, 2019

Contributor

vakrilov commented Jun 21, 2019 •

edited

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is in the PR

Both builder.ts and component-builder.ts refactored to work in webpack-only mode and to use only modules.
Implemented module-name-resolver that can resolve webpack (xml/js/css) that have file-qualifiers.

Fixes #7321
Fixes #7324
Related to NativeScript/nativescript-dev-webpack#902
Fixes #7392

cla-bot bot added the cla: yes label

vakrilov changed the title ~~Builder refactor~~ feat(bundle): support for file qualifiers in builder

manoldonev reviewed

apps/app/qualifiers-app/app-root.css Outdated Show resolved Hide resolved

manoldonev reviewed

tns-core-modules/file-system/file-name-resolver/file-name-resolver.d.ts Show resolved Hide resolved

vakrilov changed the title ~~feat(bundle): support for file qualifiers in builder~~ feat(bundle): support for file qualifiers + builder refactor

vakrilov added 5 commits


          feat(bundle): support for file qualifiers in builder

bec85be


          chore: add qualifiers test app

bded6c9


          chore: add @deprecated for file-name-resolver

dbb57e4


          fix(hmr): hmr not working for scss files

598e3c4


          chore: globals clean-up

5767b18

vakrilov force-pushed the builder-refactor branch from 96a83f3 to 5767b18

vakrilov and others added 8 commits


          shore: fix tslint

af0ea2a


          tests: uncomment test fixed by ns-dev-webpack

7f3bfa6


          Merge branch 'master' into builder-refactor

d90d471


          chore: move qualifiers app to e2e

c45f8ad


          chore: update webpack config

cd837c7


          Merge branch 'master' into builder-refactor

58ec154


          chore: tslint errors

28c9924


          Merge branch 'builder-refactor' of github.com:NativeScript/NativeScri…

ff8ed55

…pt into builder-refactor

manoldonev approved these changes


          test: fix wrong css import

947fa94

manoldonev merged commit 9fcc1dd into master

4 checks passed

4 checks passed

ci/jenkins/core-modules-tests PASSed

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details

verification/cla-signed

Details

manoldonev deleted the builder-refactor branch

vakrilov mentioned this pull request

Broken apps using 5.4 and LegacyMode=false NativeScript/nativescript-cli#4633

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.