Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mythic Beasts DNS API v2 #552

Open
trickeydan opened this issue May 31, 2020 · 1 comment
Open

Add support for Mythic Beasts DNS API v2 #552

trickeydan opened this issue May 31, 2020 · 1 comment

Comments

@trickeydan
Copy link

@trickeydan trickeydan commented May 31, 2020

Support for the Mythic Beasts DNS API v1 was introduced in #360

Mythic have now released a version 2 of their API with additional features, mostly around security using OAuth2 client credentials.

What is the procedure on this project for introducing support for this? I'd be happy to update the existing code or add support for a new mythicv2 provider.

Please could the maintainers let me know which option they'd prefer and if they would like me to work on this?

@ross
Copy link
Contributor

@ross ross commented Jun 1, 2020

What is the procedure on this project for introducing support for this? I'd be happy to update the existing code or add support for a new mythicv2 provider.

A PR that swaps out which API the provider uses would be the way to go. Provided the new API is production ready and fully replaces the previous one it probably makes sense to switch it over fully. The only thing we might want to try and do is to keep the configuration options the same if there are any meaningful changes there so that the process of switching versions is less work, ideally transparent, for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.