fix(common): add boolean to valid json for testing #37893
Conversation
pullapprove
bot
requested review from
alxhub,
IgorMinar,
jelbourn and
pkozlowski-opensource
| @@ -155,7 +159,7 @@ function _toJsonBody( | |||
| throw new Error(`Automatic conversion to ${format} is not supported for Blobs.`); | |||
| } | |||
| if (typeof body === 'string' || typeof body === 'number' || typeof body === 'object' || | |||
| Array.isArray(body)) { | |||
| typeof body === 'boolean' || Array.isArray(body)) { | |||
There was a problem hiding this comment.
Since you are here, you don't need to do the Array.isArray check because typeof body === 'object' will be true already
There was a problem hiding this comment.
@ajitsinghkaler feel free to remove this in another PR
LGTM from the public API point of view (type widening and assuming that we don't support extension of TestRequest). Still need the confirmation from the area owner (@alxhub)
Reviewed-for: public-api
Reviewed-for: fw-testing
|
@AndrewKushnir can you please run a presubmit on this |
|
@ajitsinghkaler FYI the presubmit went well. Here is a couple of next steps:
Thank you. |
boolean is a valid json but at present we cannot test Http request using boolean added support for boolean requests Fixes angular#20690
|
@AndrewKushnir rebased it |
|
@alxhub can you please review this |
ghost
mentioned this pull request
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
boolean is a valid json but at present we cannot test Http request using boolean added support for boolean requests
Fixes #20690
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #20690
What is the new behavior?
Does this PR introduce a breaking change?
Other information