Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grammatical errors #37633

Closed
wants to merge 1 commit into from
Closed

fix: grammatical errors #37633

wants to merge 1 commit into from

Conversation

@nitinknolder
Copy link
Contributor

nitinknolder commented Jun 18, 2020 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@googlebot googlebot added the cla: yes label Jun 18, 2020
@pullapprove pullapprove bot requested a review from IgorMinar Jun 18, 2020
@nitinknolder nitinknolder changed the title Fix grammatical errors fix: grammatical errors Jun 18, 2020
@petebacondarwin petebacondarwin requested a review from aikidave Jun 18, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jun 18, 2020
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
docs/DEVELOPER.md Outdated Show resolved Hide resolved
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
docs/DEVELOPER.md Outdated Show resolved Hide resolved
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
docs/DEVELOPER.md Outdated Show resolved Hide resolved
@petebacondarwin
petebacondarwin reviewed Jun 18, 2020
View changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@petebacondarwin
Copy link
Member

petebacondarwin commented Jun 18, 2020

Oh - and thank you providing this PR, by the way. I hope my comments/suggestions did not come across too harshly!
@nitinknolder
Copy link
Contributor Author

nitinknolder commented Jun 18, 2020

Oh - and thank you providing this PR, by the way. I hope my comments/suggestions did not come across too harshly!

Your Welcome, no not at all!
@petebacondarwin
petebacondarwin approved these changes Jun 18, 2020
View changes
Copy link
Member

petebacondarwin left a comment

Reviewed-for: global-docs-approvers
@pullapprove pullapprove bot requested a review from IgorMinar Jun 18, 2020
@ngbot
Copy link

ngbot bot commented Jun 18, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending status "pullapprove" is pending
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/circleci: publish_snapshot"
    pending missing required status "ci/angular: size"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.
@petebacondarwin
Copy link
Member

petebacondarwin commented Jun 18, 2020

Oh and can you please rebase on master - see https://app.circleci.com/pipelines/github/angular/angular/17225/workflows/dcd17fa3-fcae-4992-a28f-6548e2c7ba8b/jobs/741791/steps
@petebacondarwin
Copy link
Member

petebacondarwin commented Jun 18, 2020

And... (sorry) the commit messages must follow our syntax, as described (ironically) in our https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit. I would suggest just squashing all your commits into a single one during your rebase. The commit message body needs to be more than 100 characters long. Something like:

docs: fix grammatical errors in developer docs

The CONTRIBUTOR and DEVELOPER markdown docs contained a few typos
and grammatical errors, which are fixed by this commit.
@petebacondarwin
petebacondarwin approved these changes Jun 18, 2020
View changes
@nitinknolder nitinknolder force-pushed the nitinknolder:fix-grammatical-errors branch from a9ba9e6 to 8508a83 Jun 18, 2020
@nitinknolder
Copy link
Contributor Author

nitinknolder commented Jun 18, 2020

Oh and can you please rebase on master - see https://app.circleci.com/pipelines/github/angular/angular/17225/workflows/dcd17fa3-fcae-4992-a28f-6548e2c7ba8b/jobs/741791/steps

I have executed all the commands mention in the steps given above but it still showing build failure please help.
@petebacondarwin
Copy link
Member

petebacondarwin commented Jun 18, 2020

You need to rebase on the upstream master (i.e. the angular/angular master, not your local master nor your own fork). Something like

git checkout master
git pull upstream master
git checkout fix-grammatical-errors
git rebase master
@nitinknolder
docs: fix grammatical errors in developer docs
Loading status checks…
7fc1bf6 
The CONTRIBUTOR and DEVELOPER markdown docs contained a few typos
and grammatical errors, which are fixed in this commit.
@nitinknolder nitinknolder force-pushed the nitinknolder:fix-grammatical-errors branch from 8508a83 to 7fc1bf6 Jun 18, 2020
@nitinknolder
Copy link
Contributor Author

nitinknolder commented Jun 18, 2020

You need to rebase on the upstream master (i.e. the angular/angular master, not your local master nor your own fork). Something like

git checkout master
git pull upstream master
git checkout fix-grammatical-errors
git rebase master

Thanks it worked but some test cases are failing and i think it's not because of my PR please have a look and let me know.
@petebacondarwin
Copy link
Member

petebacondarwin commented Jun 18, 2020

Rerunning the failed test. It is just a bit flaky
@nitinknolder
Copy link
Contributor Author

nitinknolder commented Jun 18, 2020

Rerunning the failed test. It is just a bit flaky

Oh! thanks np.
@nitinknolder
Copy link
Contributor Author

nitinknolder commented Jun 18, 2020

Rerunning the failed test. It is just a bit flaky

I think you need to rerun the build it's still not working.
@petebacondarwin petebacondarwin requested review from gkalpak and devversion Jun 18, 2020
@gkalpak
gkalpak approved these changes Jun 18, 2020
View changes
@gkalpak gkalpak removed request for IgorMinar and devversion Jun 18, 2020
@devversion
devversion approved these changes Jun 18, 2020
View changes
mhevery added a commit that referenced this pull request Jun 18, 2020
@nitinknolder @mhevery
docs: fix grammatical errors in developer docs (#37633)
Loading status checks…
e3d5e1f 
The CONTRIBUTOR and DEVELOPER markdown docs contained a few typos
and grammatical errors, which are fixed in this commit.

PR Close #37633
@mhevery mhevery closed this in d0437b3 Jun 18, 2020
ngwattcos added a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@nitinknolder @ngwattcos
docs: fix grammatical errors in developer docs (angular#37633)
933ed28 
The CONTRIBUTOR and DEVELOPER markdown docs contained a few typos
and grammatical errors, which are fixed in this commit.

PR Close angular#37633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin

@devversion devversion

@gkalpak gkalpak

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: docs
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nitinknolder @petebacondarwin @devversion @gkalpak @googlebot @aikidave
You can’t perform that action at this time.