Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify link between prefetch limit and prefetch count in the docs #6061

Open
idavidmcdonald opened this issue Apr 30, 2020 · 4 comments
Open

Clarify link between prefetch limit and prefetch count in the docs #6061

idavidmcdonald opened this issue Apr 30, 2020 · 4 comments

Comments

@idavidmcdonald
Copy link

@idavidmcdonald idavidmcdonald commented Apr 30, 2020

Checklist

  • I have checked the issues list
    for similar or identical bug reports.
  • I have checked the pull requests list
    for existing proposed fixes.
  • I have checked the commit log
    to find out if the bug was already fixed in the master branch.
  • I have included all related issues and possible duplicate issues in this issue
    (If there are none, check this box anyway).

Related Issues and Possible Duplicates

Related Issues

  • None

Possible Duplicates

  • None

Description

https://docs.celeryproject.org/en/stable/userguide/optimizing.html#prefetch-limits
The first paragraph talks about The prefetch limit is a limit for the number of tasks (messages) a worker can reserve for itself. .

The second paragraph talks about The workers’ default prefetch count is the worker_prefetch_multiplier setting multiplied by the number of concurrency slots [‡] (processes/threads/green-threads)..

It's not clear the difference/links is between the prefetch limit and the prefetch count. Are they exactly the same things but different terminology is used in different paragraphs? If they are different things, it's clear you can change the prefetch count by editing the worker_prefetch_multiplier but no mention is made of what the value is for the prefetch limit or if it can be changed.

This is confusing.

Suggestions

If the prefetch count and prefetch limit are the same things, then the wording should be consistent across paragraphs. Optionally, if users may know them as either term, then something like the prefetch count, also sometimes known as a prefetch limit, is ... could work.

If they are different things then more description should be added to the prefetch limit to explain what it's value is and how to change it (or if it's not possible).

Thanks in advance! :)

@auvipy
Copy link
Member

@auvipy auvipy commented May 16, 2020

I would really appreciate it if you initiate a PR with your suggested modifications!

@idavidmcdonald
Copy link
Author

@idavidmcdonald idavidmcdonald commented May 18, 2020

Happy to put in a PR. Just to confirm, does this mean that it's the first case, that prefetch count and prefetch limit are referring to the same thing?

@kofiPascal
Copy link

@kofiPascal kofiPascal commented May 24, 2020

Print(hello)

@auvipy
Copy link
Member

@auvipy auvipy commented May 24, 2020

Print("Feel free come with the PR")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.