Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify link between prefetch limit and prefetch count in the docs #6061
Comments
|
I would really appreciate it if you initiate a PR with your suggested modifications! |
|
Happy to put in a PR. Just to confirm, does this mean that it's the first case, that prefetch count and prefetch limit are referring to the same thing? |
|
Print( |
|
Print("Feel free come with the PR") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
for similar or identical bug reports.
for existing proposed fixes.
to find out if the bug was already fixed in the master branch.
(If there are none, check this box anyway).
Related Issues and Possible Duplicates
Related Issues
Possible Duplicates
Description
https://docs.celeryproject.org/en/stable/userguide/optimizing.html#prefetch-limits
The first paragraph talks about
The prefetch limit is a limit for the number of tasks (messages) a worker can reserve for itself..The second paragraph talks about
The workers’ default prefetch count is the worker_prefetch_multiplier setting multiplied by the number of concurrency slots [‡] (processes/threads/green-threads)..It's not clear the difference/links is between the
prefetch limitand theprefetch count. Are they exactly the same things but different terminology is used in different paragraphs? If they are different things, it's clear you can change the prefetch count by editing theworker_prefetch_multiplierbut no mention is made of what the value is for the prefetch limit or if it can be changed.This is confusing.
Suggestions
If the
prefetch countandprefetch limitare the same things, then the wording should be consistent across paragraphs. Optionally, if users may know them as either term, then something likethe prefetch count, also sometimes known as a prefetch limit, is ...could work.If they are different things then more description should be added to the
prefetch limitto explain what it's value is and how to change it (or if it's not possible).Thanks in advance! :)